Skip to content

[test] Add description to the collective halo tests #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2019
Merged

[test] Add description to the collective halo tests #690

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d88853d
added test description
ajocksch Feb 25, 2019
afc5e56
implemented changes required
ajocksch Mar 4, 2019
e0954e0
Merge branch 'master' into benchmarks/mch_description
vkarak Mar 7, 2019
2f4d11f
Merge branch 'master' into benchmarks/mch_description
vkarak Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cscs-checks/mch/collectives_halo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import reframe.utility.sanity as sn


class CollectivesBaseTest(rfm.RegressionTest):
class CommunicationTestBase(rfm.RegressionTest):
def __init__(self, variant, bench_reference):
super().__init__()
self.valid_systems = ['dom:gpu', 'daint:gpu', 'kesch:cn']
Expand Down Expand Up @@ -86,8 +86,11 @@ def setup(self, *args, **kwargs):
'--cpu_bind=q']


# the values default, nocomm and nocomp refer to the different parts
# of the check where the time is measured; default == all
# nocomm == no communication nocomp == no computation
@rfm.parameterized_test(['default'], ['nocomm'], ['nocomp'])
class AlltoallvTest(CollectivesBaseTest):
class AlltoallvTest(CommunicationTestBase):
def __init__(self, variant):
super().__init__(variant,
{
Expand All @@ -102,13 +105,14 @@ def __init__(self, variant):
'default': 0.0138493
}
})
self.descr = 'Alltoall communication test'
self.strict_check = False
self.sourcesdir = 'https://github.com/cosunae/comm_overlap_bench'
self.prebuild_cmd = ['git checkout alltoallv']


@rfm.parameterized_test(['default'], ['nocomm'], ['nocomp'])
class HaloExchangeTest(CollectivesBaseTest):
class HaloExchangeTest(CommunicationTestBase):
def __init__(self, variant):
super().__init__(variant,
{
Expand All @@ -123,5 +127,6 @@ def __init__(self, variant):
'default': 2.53509
}
})
self.descr = 'Halo-cell exchange test'
self.sourcesdir = 'https://github.com/MeteoSwiss-APN/comm_overlap_bench.git'
self.prebuild_cmd = ['git checkout barebones']