Skip to content

[bugfix] Fix unit test failure with EBUSY when running on NFS filesystem #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2019
Merged

[bugfix] Fix unit test failure with EBUSY when running on NFS filesystem #715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d1c39
Fix unittest bug when running on nfs filesystems
Mar 14, 2019
da8a35f
Merge branch 'master' into bugfix/unittest_nfs_problem
vkarak Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions reframe/utility/os_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,17 @@ def ignore(dir, contents):
def rmtree(*args, max_retries=3, **kwargs):
"""Persistent version of ``shutil.rmtree()``.

If ``shutil.rmtree()`` with ``ENOTEMPTY``, retry up to ``max_retries``
times to delete the directory.
If ``shutil.rmtree()`` fails with ``ENOTEMPTY`` or ``EBUSY``, retry up to
``max_retries`times to delete the directory.

This version of ``rmtree()`` is mostly provided to work around a race
condition between when ``sacct`` reports a job as completed and when the
Slurm epilog runs. See https://github.com/eth-cscs/reframe/issues/291 for
more information.
Furthermore, it offers a work around for nfs file systems where a ``.nfs*``
file may be present during the ``rmtree()`` call which throws a busy
device/resource error. See https://github.com/eth-cscs/reframe/issues/712
for more information.

``args`` and ``kwargs`` are passed through to ``shutil.rmtree()``.

Expand All @@ -200,7 +204,7 @@ def rmtree(*args, max_retries=3, **kwargs):
except OSError as e:
if i == max_retries:
raise
elif e.errno == errno.ENOTEMPTY:
elif e.errno in {errno.ENOTEMPTY, errno.EBUSY}:
pass
else:
raise
Expand Down