Skip to content

[test] Add mpiP parallel test #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 28, 2019
Merged

[test] Add mpiP parallel test #720

merged 8 commits into from
Mar 28, 2019

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Mar 22, 2019 •
edited
Loading

@jgphpc jgphpc self-assigned this Mar 22, 2019
@jgphpc jgphpc requested review from kraushm and teojgo March 22, 2019 14:37
@pep8speaks
Copy link

pep8speaks commented Mar 22, 2019 •
edited
Loading

Hello @jgphpc, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-03-28 23:03:24 UTC

@jgphpc jgphpc changed the title [test] Add mpip parallel test [test] Add mpiP parallel test Mar 22, 2019
@jgphpc
Copy link
Contributor Author

jgphpc commented Mar 25, 2019

@jenkins-cscs retry all

@codecov-io
Copy link

codecov-io commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          77       77           
  Lines        9504     9504           
=======================================
  Hits         8724     8724           
  Misses        780      780

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92c188...abe1ec6. Read the comment docs.

victorusu
victorusu requested changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a very small change request.

@vkarak vkarak added this to the Upcoming sprint milestone Mar 27, 2019
victorusu
victorusu approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vkarak
vkarak approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Nice PR @jgphpc.

@vkarak vkarak merged commit 65fa582 into reframe-hpc:master Mar 28, 2019
@jgphpc jgphpc deleted the mpip branch March 29, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

@teojgo teojgo Awaiting requested review from teojgo

@kraushm kraushm Awaiting requested review from kraushm

Assignees

@jgphpc jgphpc

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w13

Development

Successfully merging this pull request may close these issues.

5 participants

@jgphpc @pep8speaks @codecov-io @vkarak @victorusu