Skip to content

[test] Update perftools check for CLE7 #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 11, 2019
Merged

[test] Update perftools check for CLE7 #731

merged 7 commits into from
Apr 11, 2019

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Apr 3, 2019 •
edited
Loading

@jgphpc jgphpc self-assigned this Apr 3, 2019
@jgphpc jgphpc requested review from teojgo and vkarak April 3, 2019 20:19
@jgphpc jgphpc changed the title [test] updating check for cle7 [test] updating perftools check for cle7 Apr 3, 2019
vkarak
vkarak requested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's fine. Just a minor comment.

@vkarak vkarak changed the title [test] updating perftools check for cle7 [test] Update perftools check for CLE7 Apr 4, 2019
@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 9, 2019

failed only because it could not load module PrgEnv-pgi
@jenkins-cscs retry all

@codecov-io
Copy link

codecov-io commented Apr 10, 2019 •
edited
Loading

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          76       76           
  Lines        9501     9501           
=======================================
  Hits         8719     8719           
  Misses        782      782

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f6d66...d412f17. Read the comment docs.

@jgphpc jgphpc requested a review from vkarak April 10, 2019 13:24
@vkarak vkarak added this to the ReFrame sprint 2019w15 milestone Apr 11, 2019
@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2019

@jenkins-cscs retry daint dom

@vkarak vkarak merged commit de76a62 into reframe-hpc:master Apr 11, 2019
@jgphpc jgphpc deleted the MAINT-17 branch April 12, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@jgphpc jgphpc

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w15

Development

Successfully merging this pull request may close these issues.

4 participants

@jgphpc @codecov-io @vkarak @teojgo