Skip to content

[feat] Add option to print performance report #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2019
Merged

[feat] Add option to print performance report #733

merged 6 commits into from
Apr 11, 2019

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Apr 4, 2019

Closes #634

@rsarm rsarm added this to the ReFrame sprint 2019w13 milestone Apr 4, 2019
@rsarm rsarm self-assigned this Apr 4, 2019
@rsarm rsarm requested a review from vkarak April 4, 2019 12:55
@vkarak vkarak requested review from teojgo and victorusu April 4, 2019 12:56
teojgo
teojgo requested changes Apr 4, 2019
View reviewed changes
victorusu
victorusu approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vkarak
vkarak requested changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ready to be merged. I have several comments. I'll come back with more details.

vkarak
vkarak requested changes Apr 6, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #733 into master will decrease coverage by 0.25%.
The diff coverage is 27.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   91.76%   91.51%   -0.26%     
==========================================
  Files          76       76              
  Lines        9501     9532      +31     
==========================================
+ Hits         8719     8723       +4     
- Misses        782      809      +27
Impacted Files Coverage Δ
reframe/frontend/statistics.py 67.64% <3.84%> (-21.83%) ⬇️
reframe/core/pipeline.py 93.45% <80%> (-0.23%) ⬇️
reframe/frontend/cli.py 81.27% <83.33%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a07360...9397fc1. Read the comment docs.

vkarak
vkarak requested changes Apr 10, 2019
View reviewed changes
@rsarm
Copy link
Contributor Author

rsarm commented Apr 11, 2019

@jenkins-cscs retry kesch

@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2019

@jenkins-cscs retry dom

@vkarak vkarak changed the title [feat] Add performance report to output [feat] Add option to print performance report Apr 11, 2019
@vkarak vkarak merged commit a534df0 into reframe-hpc:master Apr 11, 2019
@rsarm rsarm deleted the feat/benchmark-mode branch November 26, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@rsarm rsarm

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w15

Development

Successfully merging this pull request may close these issues.

5 participants

@rsarm @codecov-io @vkarak @victorusu @teojgo