[test] Sort cores list in affinity test before comparing #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sebkelle1 Please have a look at the PR title guide: https://github.com/eth-cscs/reframe/wiki/Contributing-to-ReFrame#pull-request-policy |
sekelle
changed the title
rsarm
approved these changes
Apr 5, 2019
vkarak
changed the title
vkarak
requested changes
Apr 5, 2019
cscs-checks/prgenv/affinity_check.py
Outdated
| super().setup(partition, environ, **job_opts) | ||
|
|
||
| @sn.sanity_function | ||
| def sn_sorted(self, lst): |
Contributor
There was a problem hiding this comment.
This is already provided by ReFrame. sn.sorted() should be fine.
vkarak
changed the title
vkarak
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be my suggestion to fix the test. I sort the list of cores, because arguably
for performance we don't care which OpenMP thread is executed on which core.
It should be enough to check that the list of cores contains no duplicates and the total
number of distinct cores is the same relative to the reference.