Skip to content

[bugfix] Fix duplicate module commands emitted while executing test cases #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2019
Merged

[bugfix] Fix duplicate module commands emitted while executing test cases #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7295c4
Clone environments in test cases
Apr 7, 2019
7a28c9e
Deep copy partitions as well
Apr 7, 2019
4477a12
Merge branch 'master' into bugfix/duplicate-module-loads
vkarak Apr 8, 2019
bb978f6
Merge branch 'master' into bugfix/duplicate-module-loads
vkarak Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions reframe/frontend/executors/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
ReframeFatalError, TaskExit)
from reframe.frontend.printer import PrettyPrinter
from reframe.frontend.statistics import TestStats
from reframe.utility.sandbox import Sandbox

ABORT_REASONS = (KeyboardInterrupt, ReframeFatalError, AssertionError)

Expand All @@ -23,10 +22,8 @@ class TestCase:
def __init__(self, check, partition, environ):
self.__check_orig = check
self.__check = copy.deepcopy(check)

# Environments and partitions are immutable; no need to clone them
self.__partition = partition
self.__environ = environ
self.__environ = copy.deepcopy(environ)
self.__partition = copy.deepcopy(partition)

def __iter__(self):
# Allow unpacking a test case with a single liner:
Expand Down Expand Up @@ -220,7 +217,6 @@ def __init__(self, policy, printer=None, max_retries=0):
self._stats = TestStats()
self._policy.stats = self._stats
self._policy.printer = self._printer
self._sandbox = Sandbox()
self._environ_snapshot = EnvironmentSnapshot()

def __repr__(self):
Expand Down
8 changes: 0 additions & 8 deletions reframe/utility/sandbox.py
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions unittests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,21 +108,6 @@ class FieldTester:
self.assertRaises(ValueError, exec, 'tester.field = (100, 3, 65)',
globals(), locals())

def test_sandbox(self):
from reframe.core.environments import Environment
from reframe.core.systems import System
from reframe.utility.sandbox import Sandbox

environ = Environment('myenv')
system = System('mysystem')

sandbox = Sandbox()
sandbox.environ = environ
sandbox.system = system

self.assertIsNot(system, sandbox.system)
self.assertIsNot(environ, sandbox.environ)

def test_proxy_field(self):
class Target:
def __init__(self):
Expand Down