[doc] Fix reference to exclusive_access in tutorial
#742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You now named the variable exclusive_access, and not just exclusive anymore. This needs to be reflected in the documentation
Collaborator
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 77 77
Lines 9527 9527
=======================================
Hits 8740 8740
Misses 787 787Continue to review full report at Codecov.
|
Contributor
Author
|
Sure. I verified, that self.exclusive does not providing the mentioned feature but self.exclusive_access does.
From: jenkins-cscs <notifications@github.com>
Sent: Tuesday, 9 April 2019 12:15 PM
To: eth-cscs/reframe <reframe@noreply.github.com>
Cc: mand35 <mandes.schoenherr@nesi.org.nz>; Author <author@noreply.github.com>
Subject: Re: [eth-cscs/reframe] tutorial: exclusive access (#742)
Can I test this patch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#742 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AVm5Fk1w5EHQjiFeeUGh6cPBOOgoilwnks5ve9uHgaJpZM4cjWGT> . <https://github.com/notifications/beacon/AVm5FtzwoIv0qPcqXkFkfiGx5_X2ixl1ks5ve9uHgaJpZM4cjWGT.gif>
|
vkarak
changed the title
exclusive_access in tutorial
Contributor
|
@mand35 Thanks for spotting this! It has always been |
vkarak
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You now named the variable exclusive_access, and not just exclusive anymore. This needs to be reflected in the documentation