Skip to content

[test] Update magma tests #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2019
Merged

[test] Update magma tests #754

merged 2 commits into from
Apr 12, 2019

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 11, 2019 •
edited
Loading

This PR fixes several issues with the MAGMA tests:

  1. Performance thresholds were completely wrong! They were allowing indefinitely lower performances. This was fixed.
  2. Units are added to the reference values.
  3. Remove all unnecessary specializations.
  4. Ported them to the new s/w stack (tests only for MAGMA 2.4)

@vkarak vkarak added this to the ReFrame sprint 2019w15 milestone Apr 11, 2019
@vkarak vkarak requested review from ajocksch and teojgo April 11, 2019 13:53
@vkarak vkarak self-assigned this Apr 11, 2019
@vkarak
Copy link
Contributor Author

vkarak commented Apr 11, 2019

@jenkins-cscs retry none

@vkarak vkarak merged commit b18cb96 into reframe-hpc:master Apr 12, 2019
@vkarak vkarak deleted the check/magma-update branch April 12, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teojgo teojgo teojgo approved these changes

@ajocksch ajocksch Awaiting requested review from ajocksch

Assignees

@vkarak vkarak

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w15

Development

Successfully merging this pull request may close these issues.

2 participants

@vkarak @teojgo