Skip to content

[bugfix] Fix exception message formatting in reservation node extraction #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2019
Merged

[bugfix] Fix exception message formatting in reservation node extraction #793

merged 3 commits into from
May 21, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented May 20, 2019

No description provided.

@teojgo teojgo requested a review from vkarak May 20, 2019 15:35
@teojgo teojgo self-assigned this May 21, 2019
vkarak
vkarak approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vkarak vkarak added this to the ReFrame sprint 2019w20 milestone May 21, 2019
vkarak
vkarak reviewed May 21, 2019
View reviewed changes
@vkarak vkarak changed the title [bugfix] Fix variable name in reservation node extraction [bugfix] Fix exception message formatting in reservation node extraction May 21, 2019
@vkarak
Copy link
Contributor

vkarak commented May 21, 2019

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented May 21, 2019 •
edited
Loading

Codecov Report

Merging #793 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          76       76           
  Lines        9551     9551           
=======================================
  Hits         8741     8741           
  Misses        810      810
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 59.07% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a792db8...f327781. Read the comment docs.

@vkarak vkarak merged commit 61698aa into reframe-hpc:master May 21, 2019
@teojgo teojgo deleted the bugfix/reservation_flex_alloc_tasks branch May 22, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w20

Development

Successfully merging this pull request may close these issues.

3 participants

@teojgo @vkarak @codecov-io