From eb2940bfc5c0926eda72b9f59762f04355bf1bb3 Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Mon, 20 May 2019 17:35:14 +0200 Subject: [PATCH 1/2] Fix variable name in reservation node extraction --- reframe/core/schedulers/slurm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reframe/core/schedulers/slurm.py b/reframe/core/schedulers/slurm.py index 110dd6b50c..22b1d4d340 100644 --- a/reframe/core/schedulers/slurm.py +++ b/reframe/core/schedulers/slurm.py @@ -233,7 +233,7 @@ def _get_reservation_nodes(self, reservation): reservation_nodes = node_match[1] else: raise JobError("could not extract the nodes names for " - "reservation '%s'" % valid_reservation) + "reservation '%s'" % reservation) completed = _run_strict('scontrol -a show -o %s' % reservation_nodes) node_descriptions = completed.stdout.splitlines() From 6b2b929d5e36d2e6512b4d3b0e6b41db4fe752a8 Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Tue, 21 May 2019 19:10:44 +0200 Subject: [PATCH 2/2] Address PR comments --- reframe/core/schedulers/slurm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reframe/core/schedulers/slurm.py b/reframe/core/schedulers/slurm.py index 22b1d4d340..321da8b519 100644 --- a/reframe/core/schedulers/slurm.py +++ b/reframe/core/schedulers/slurm.py @@ -232,7 +232,7 @@ def _get_reservation_nodes(self, reservation): if node_match: reservation_nodes = node_match[1] else: - raise JobError("could not extract the nodes names for " + raise JobError("could not extract the node names for " "reservation '%s'" % reservation) completed = _run_strict('scontrol -a show -o %s' % reservation_nodes)