Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented May 24, 2019

Abstract classes must derive from abc.ABC.

Abstract classes must derive from abc.ABC.
@vkarak vkarak added this to the ReFrame sprint 2019w20 milestone May 24, 2019
@vkarak vkarak requested review from teojgo and victorusu May 24, 2019 16:18
@vkarak vkarak self-assigned this May 24, 2019
@vkarak
Copy link
Contributor Author

vkarak commented May 25, 2019

@jenkins-cscs retry dom

@vkarak
Copy link
Contributor Author

vkarak commented May 27, 2019

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #805 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   91.55%   91.55%   -0.01%     
==========================================
  Files          80       80              
  Lines        9976     9975       -1     
==========================================
- Hits         9134     9133       -1     
  Misses        842      842
Impacted Files Coverage Δ
unittests/test_modules.py 82.11% <100%> (ø) ⬆️
reframe/frontend/executors/__init__.py 98.23% <100%> (-0.01%) ⬇️
unittests/test_buildsystems.py 99.15% <100%> (ø) ⬆️
unittests/test_schedulers.py 97.67% <100%> (ø) ⬆️
reframe/core/buildsystems.py 97.11% <100%> (ø) ⬆️
reframe/utility/versioning.py 89.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7ff13...1a530cb. Read the comment docs.

@vkarak vkarak merged commit 8b6a3b3 into reframe-hpc:master May 27, 2019
@vkarak vkarak deleted the refactor/fix-abstract-classes branch May 27, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants