Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented May 29, 2019

  • Limit the default max_concurrency for make based build systems
    to 1.

  • Make the corresponding changes to unittests and docs.

Fixes #792

* Limit the default `max_concurrency` for make based build systems
  to `1`.

* Make the corresponding changes to unittests and docs.
@teojgo teojgo added this to the ReFrame sprint 2019w22 milestone May 29, 2019
@teojgo teojgo requested a review from vkarak May 29, 2019 07:18
@teojgo teojgo self-assigned this May 29, 2019
@vkarak vkarak requested a review from victorusu June 5, 2019 07:25
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [feat] Limit default 'max_concurrency' of make to '1' [feat] Limit concurrent build jobs to 1 by default Jun 5, 2019
@vkarak vkarak changed the title [feat] Limit concurrent build jobs to 1 by default [feat] Limit concurrent build jobs to 1 by default in build systems Jun 5, 2019
@vkarak
Copy link
Contributor

vkarak commented Jun 5, 2019

@jenkins-cscs retry dom

@codecov-io
Copy link

Codecov Report

Merging #810 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files          80       80           
  Lines        9975     9975           
=======================================
  Hits         9133     9133           
  Misses        842      842
Impacted Files Coverage Δ
reframe/core/buildsystems.py 97.11% <100%> (ø) ⬆️
unittests/test_buildsystems.py 99.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3bc335...6141ebe. Read the comment docs.

@vkarak vkarak merged commit 636b95d into reframe-hpc:master Jun 5, 2019
@teojgo teojgo deleted the feat/limit_concerrency_make branch June 13, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit maximum build concurrency to one job by default

4 participants