Skip to content

[test] Make the Jacobi check generic #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2019
Merged

[test] Make the Jacobi check generic #819

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6995fed
jacobi
jgphpc Jun 5, 2019
7924290
fix for reviewer
jgphpc Jun 6, 2019
5ed0e45
fix for reviewer
jgphpc Jun 6, 2019
e1df06d
Merge branch 'master' into UES-384_jacobi
jgphpc Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 37 additions & 25 deletions cscs-checks/tools/profiling_and_debugging/notool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
from reframe.core.fields import ScopedDict


@rfm.required_version('>=2.14')
@rfm.parameterized_test(['C++'], ['F90'])
class JacobiNoToolHybrid(rfm.RegressionTest):
def __init__(self, lang):
super().__init__()
self.name = '%s_%s' % (type(self).__name__, lang.replace('+', 'p'))
self.descr = 'Jacobi (without tool) %s check' % lang
self.language = lang
self.name = '%s_%s' % (type(self).__name__, lang.replace('+', 'p'))
self.valid_systems = ['daint:gpu', 'daint:mc', 'dom:gpu', 'dom:mc']
self.valid_prog_environs = ['PrgEnv-cray', 'PrgEnv-gnu',
'PrgEnv-intel', 'PrgEnv-pgi']
Expand All @@ -23,66 +21,80 @@ def __init__(self, lang):
'PrgEnv-pgi': ['-O2', '-g', '-mp']
}
self.sourcesdir = os.path.join('src', lang)
self.executable = './jacobi'
self.build_system = 'Make'
self.executable = './jacobi'
# NOTE: Restrict concurrency to allow creation of Fortran modules
if lang == 'F90':
self.build_system.max_concurrency = 1

self.num_tasks = 3
self.num_tasks_per_node = 3
self.num_cpus_per_task = 4
self.num_iterations = 200
self.num_tasks_per_core = 1
self.use_multithreading = False
self.num_iterations = 100
self.variables = {
'OMP_NUM_THREADS': str(self.num_cpus_per_task),
'ITERATIONS': str(self.num_iterations),
'OMP_PROC_BIND': 'true',
'CRAYPE_LINK_TYPE': 'dynamic'
}
# OpenMP support varies between compilers:
self.openmp_versions = ScopedDict({
'PrgEnv-cray': {'version': 201511},
'PrgEnv-gnu': {'version': 201511},
'PrgEnv-intel': {'version': 201611},
'PrgEnv-pgi': {'version': 201307},
})
# a scopedict is better than this:
# if (self.language == 'C++' and
self.lang = lang
# The scopedict (above) is better than this:
# if (self.lang == 'C++' and
# self.current_environ.name == 'PrgEnv-pgi'):
# self.omp_versions['PrgEnv-pgi'] = '200805'

self.maintainers = ['JG', 'MK']
self.tags = {'production'}
if self.current_system.name in {'dom', 'daint'}:
# get general info about the environment:
self.post_run = ['module list -t']
self.perf_patterns = {
'elapsed_time': sn.extractsingle(r'Elapsed Time\s*:\s+(\S+)',
self.stdout, 1, float)
}
self.reference_prgenv = {
'PrgEnv-gnu': (0.90, -0.6, None),
'PrgEnv-cray': (0.90, -0.6, None),
'PrgEnv-intel': (0.90, -0.6, None),
'PrgEnv-pgi': (18.0, -0.6, None),
}
self.reference = {
'*': {
'elapsed_time': (0, None, None)
'elapsed_time': (0, None, None, 's')
}
}
self.post_run = ['module list -t']

self.maintainers = ['JG', 'MK']
self.tags = {'production'}
if lang == 'C++':
self.reference_prgenv = {
'PrgEnv-cray': (0.38, -0.6, None, 's'),
'PrgEnv-gnu': (0.38, -0.6, None, 's'),
'PrgEnv-intel': (0.38, -0.6, None, 's'),
'PrgEnv-pgi': (18.0, -0.6, None, 's'),
}
elif lang == 'F90':
self.reference_prgenv = {
'PrgEnv-cray': (0.17, -0.6, None, 's'),
'PrgEnv-gnu': (0.17, -0.6, None, 's'),
'PrgEnv-intel': (0.17, -0.6, None, 's'),
'PrgEnv-pgi': (18.0, -0.6, None, 's'),
}

def setup(self, partition, environ, **job_opts):
super().setup(partition, environ, **job_opts)
environ_name = self.current_environ.name
prgenv_flags = self.prgenv_flags[environ_name]
envname = self.current_environ.name
# if generic, falls back to -g:
prgenv_flags = self.prgenv_flags.get(envname, ['-g'])
self.build_system.cflags = prgenv_flags
self.build_system.cxxflags = prgenv_flags
self.build_system.fflags = prgenv_flags
self.build_system.ldflags = ['-lm']
found_version = sn.extractsingle(
r'OpenMP-\s*(\d+)', self.stdout, 1, int)
ompversion_key = '%s:%s:version' % (environ_name, self.language)
found_version = sn.extractsingle(r'OpenMP-\s*(\d+)', self.stdout, 1,
int)
ompversion_key = '%s:%s:version' % (envname, self.lang)
self.sanity_patterns = sn.all([
sn.assert_eq(found_version, self.openmp_versions[ompversion_key]),
sn.assert_found('SUCCESS', self.stdout),
])
self.reference['*:elapsed_time'] = self.reference_prgenv[environ_name]
if self.current_system.name in {'dom', 'daint'}:
self.reference['*:elapsed_time'] = self.reference_prgenv[envname]