[bugfix] Fix timing in the allocation speed test #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vkarak can you check that this fixes the problem in the timings for your case ? |
Contributor
|
looks ok |
toxa81
approved these changes
Jun 7, 2019
Contributor
Author
|
@jenkins-cscs retry all |
vkarak
requested changes
Jun 8, 2019
|
|
||
| /* time to allocate + fill */ | ||
| std::fill(ptr.get(), ptr.get() + n, 0); | ||
| char* ptr = (char*)std::malloc(n); |
Contributor
There was a problem hiding this comment.
I would add a small comment with the rationale of not using unique_ptr here.
vkarak
approved these changes
Jun 11, 2019
Contributor
|
@jenkins-cscs retry kesch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #802