Skip to content

[bugfix] Fix how Slurm states are mapped internally by the Slurm backend #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2019
Merged

[bugfix] Fix how Slurm states are mapped internally by the Slurm backend #845

merged 1 commit into from
Jun 28, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jun 28, 2019

Fixes #844

@teojgo teojgo added this to the ReFrame sprint 2019w23 milestone Jun 28, 2019
@teojgo teojgo requested a review from vkarak June 28, 2019 06:17
@teojgo teojgo self-assigned this Jun 28, 2019
vkarak
vkarak approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@vkarak
Copy link
Contributor

vkarak commented Jun 28, 2019

@jenkins-cscs retry none

@vkarak
Copy link
Contributor

vkarak commented Jun 28, 2019

So it appears that the job was entering the CONFIGURING state and the Slurm backend was erroneously reporting as finished. Then when we were checking in the unit test if the job has actually finished (an operation that triggers a status update), the job was in (most probably) the RUNNING phase, and finished() returned False.

@vkarak vkarak changed the title [bugfix] Fix test_poll failure on dom for squeue [bugfix] Fix how Slurm states are mapped internally by the Slurm backend Jun 28, 2019
@vkarak
Copy link
Contributor

vkarak commented Jun 28, 2019

This regression was introduced in #835.

@vkarak vkarak merged commit acf2038 into reframe-hpc:master Jun 28, 2019
@teojgo teojgo deleted the bugfix/test_poll_squeue branch July 1, 2019 09:19
@vkarak vkarak mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w23

Development

Successfully merging this pull request may close these issues.

Squeue backend unit tests fail on Dom

2 participants

@teojgo @vkarak