Skip to content

Conversation

@kraushm
Copy link
Contributor

@kraushm kraushm commented Jul 5, 2019

Updating the environments to account for the new meta-modules, which became necessary to support two different toolchain versions. The config file targets the production PE/17.06.

@kraushm kraushm requested review from victorusu and vkarak July 5, 2019 07:44
@kraushm kraushm self-assigned this Jul 5, 2019
@kraushm
Copy link
Contributor Author

kraushm commented Jul 5, 2019

@jenkins-cscs retry all

@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files          80       80           
  Lines       10302    10302           
=======================================
  Hits         9448     9448           
  Misses        854      854

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ae29a...599c2b9. Read the comment docs.

@kraushm kraushm changed the title [kesch] Update system config for Kesch WIP: [kesch] Update system config for Kesch Jul 5, 2019
@vkarak vkarak changed the title WIP: [kesch] Update system config for Kesch [wip] [kesch] Update system config for Kesch Jul 5, 2019
@vkarak
Copy link
Contributor

vkarak commented Jul 5, 2019

@kraushm Why is this a WIP?

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts in the config/cscs-ci.py in favor of the current master, i.e., overwrite your changes completely.

@kraushm
Copy link
Contributor Author

kraushm commented Jul 8, 2019

@jenkins-cscs retry all

2 similar comments
@kraushm
Copy link
Contributor Author

kraushm commented Jul 8, 2019

@jenkins-cscs retry all

@kraushm
Copy link
Contributor Author

kraushm commented Jul 8, 2019

@jenkins-cscs retry all

@kraushm kraushm changed the title [wip] [kesch] Update system config for Kesch [kesch] Update system config for Kesch Jul 8, 2019
@vkarak vkarak changed the title [kesch] Update system config for Kesch [ci] Update system config for Kesch Jul 8, 2019
@vkarak vkarak added this to the ReFrame sprint 2019w23 milestone Jul 8, 2019
'type': 'ProgEnvironment',
'modules': ['PrgEnv-pgi/17.10_gdr'],
'modules': ['PE/17.06',
'PrgEnv-pgi/18.5'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was that we don't need both PrgEnv-pgi and PrgEnv-pgi-nompi, since they load completely the same modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this.

@vkarak vkarak merged commit 8b9aeb3 into reframe-hpc:master Jul 9, 2019
@kraushm kraushm deleted the kesch/config branch June 30, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants