Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 12, 2019

  • Add logging info when an array job is detected and during file merging.

Related to #840
Fixes #839

* Add logging info when an array job is detected and during file merging.
@bcfriesen
Copy link
Contributor

Hi @teojgo,

thanks for working on this - unfortunately it still does not work for me. I noticed that the directory from which I invoke ReFrame to run the job arrays test now has a .out and .err file, but both are blank. The .out_0 and .out_1 and .err_0 and .err_1 files are all still in the stage dir.

@teojgo
Copy link
Contributor Author

teojgo commented Jul 13, 2019

@bcfriesen this is strange. Can you post the log lines mentioning the merging of files?

@victorusu victorusu added this to the ReFrame sprint 2019w29 milestone Jul 16, 2019
@bcfriesen
Copy link
Contributor

Hi @teojgo,

hmm, I see no logs discussing merging files. I am running on commit cdd4501 and using reframe -v. Should I be doing something else?

@teojgo
Copy link
Contributor Author

teojgo commented Jul 16, 2019

Hello @bcfriesen,

Please checkout to the branch of this PR and run again. Then the reframe.log should contain information regarding the merging of files.

@bcfriesen
Copy link
Contributor

Hi @teojgo,

ahh now it all works. Sorry I think I was one commit behind this PR. Everything works now - the merging message is in the log, and the job arrays test passes. Thanks!

@teojgo
Copy link
Contributor Author

teojgo commented Jul 17, 2019

@bcfriesen thank you for the feedback. We are going to review now and merge the PR.

@vkarak vkarak changed the title [bugfix] Change to workdir before merging job array files [bugfix] Change to working directory before merging job array files Jul 17, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor

vkarak commented Jul 17, 2019

@jenkins-cscs retry all

@vkarak vkarak merged commit 770683f into reframe-hpc:master Jul 17, 2019
@teojgo teojgo deleted the bugfix/slurm_job_array_file_merge branch July 18, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame fails to detect job status of Slurm job arrays

4 participants