Skip to content

[bugfix] Change to working directory before merging job array files #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2019
Merged

[bugfix] Change to working directory before merging job array files #869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007c0e2
Change to workdir before merging job array files
Jul 12, 2019
8dc04cb
Merge branch 'master' into bugfix/slurm_job_array_file_merge
Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions reframe/core/schedulers/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,15 @@ def _get_default_partition(self):
return None

def _merge_files(self):
output_glob = glob.glob(self.stdout + '_*')
err_glob = glob.glob(self.stderr + '_*')
os_ext.concat_files(self.stdout, *output_glob, overwrite=True)
os_ext.concat_files(self.stderr, *err_glob, overwrite=True)
with os_ext.change_dir(self.workdir):
out_glob = glob.glob(self.stdout + '_*')
err_glob = glob.glob(self.stderr + '_*')
getlogger().debug(
'merging job array output files: %s' % ', '.join(out_glob))
os_ext.concat_files(self.stdout, *out_glob, overwrite=True)
getlogger().debug(
'merging job array error files: %s' % ','.join(err_glob))
os_ext.concat_files(self.stderr, *err_glob, overwrite=True)

def filter_nodes(self, nodes, options):
option_parser = ArgumentParser()
Expand Down Expand Up @@ -422,6 +427,7 @@ def is_job_array(self):
jobs_array = parsed_args.array
if jobs_array:
self._is_job_array = True
getlogger().debug('detected job array option: %s' % jobs_array)
else:
self._is_job_array = False

Expand Down