[test] Fix openacc_cuda_mpi_cppstd.F90 #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace deprecated cudaThreadSynchronize() with cudaDeviceSynchronize()
Contributor
|
it was in fact already failing before the fix, and we try to correct but obviously we did it wrong |
lxavier
reviewed
Aug 9, 2019
| write (*,*) "Result : FAIL" | ||
| write (*,*) "Expected value sum(f1): ", EXPECTED_CUDA_SUM, "actual value:", sum(f1) | ||
| else if (sum(f3) /= EXPECTED_CPP_STD_SUM) then | ||
| else if (sum(f2) /= EXPECTED_CPP_STD_SUM) then |
Contributor
There was a problem hiding this comment.
no it should be f3, but the error is on the right side
Contributor
There was a problem hiding this comment.
like this:
else if (sum(f3) /= EXPECTED_CUDA_SUM) then
?
Contributor
There was a problem hiding this comment.
Yes, basicall revertting the change from PR #888 only the file openacc_cuda_mpi_cppstd.F90 . I did that with Carlos, because the code was failling. But probably because we did too quickly and did not compile with the correct OpenACC flag. Note that you also need to adapt the
write (*,*) "Expected value sum(f3): ", EXPECTED_CUDA_SUM, "actual value:", sum(f3)
below
ajocksch
reviewed
Aug 13, 2019
Co-Authored-By: Andreas Jocksch <andreas.jocksch@cscs.ch>
ajocksch
reviewed
Aug 13, 2019
Co-Authored-By: Andreas Jocksch <andreas.jocksch@cscs.ch>
ajocksch
approved these changes
Aug 13, 2019
lucamar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging the pull request #889, we are getting the following error:
I think that there is a mistake in the fix submitted by @cosunae: the array that should be checked for the
EXPECTED_CPP_STD_SUMisf2and notf3, since only the first one is called as argument incall_cpp_std. What do you think @lxavier?P.S.: I have replaced
cudaThreadSynchronize()withcudaDeviceSynchronize()incompute_cuda.cusince the first one is deprecated.