Skip to content

[feat] Print compiler commands and flags when showing the environment configuration #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2019
Merged

[feat] Print compiler commands and flags when showing the environment configuration #918

merged 6 commits into from
Sep 5, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Sep 2, 2019

Fixes #884

@teojgo teojgo added this to the ReFrame sprint 2019w35 milestone Sep 2, 2019
@teojgo teojgo requested review from victorusu and vkarak September 2, 2019 07:29
@teojgo teojgo self-assigned this Sep 2, 2019
@vkarak vkarak changed the title [feat] Return compiler commands and flags in prgenv details [feat] Return compiler commands and flags when showing the environment configuration Sep 2, 2019
vkarak
vkarak requested changes Sep 2, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Sep 3, 2019 •
edited
Loading

Codecov Report

Merging #918 into master will decrease coverage by <.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #918      +/-   ##
=========================================
- Coverage    91.7%   91.7%   -0.01%     
=========================================
  Files          78      78              
  Lines       10340   10350      +10     
=========================================
+ Hits         9482    9491       +9     
- Misses        858     859       +1
Impacted Files Coverage Δ
reframe/core/environments.py 87.27% <70%> (-1.12%) ⬇️
reframe/core/config.py 85.71% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdf0cf...e7798f7. Read the comment docs.

vkarak
vkarak requested changes Sep 3, 2019
View reviewed changes
vkarak
vkarak requested changes Sep 3, 2019
View reviewed changes
vkarak
vkarak requested changes Sep 5, 2019
View reviewed changes
vkarak
vkarak approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@vkarak vkarak changed the title [feat] Return compiler commands and flags when showing the environment configuration [feat] Print compiler commands and flags when showing the environment configuration Sep 5, 2019
@vkarak vkarak merged commit 3a7dfb3 into reframe-hpc:master Sep 5, 2019
@teojgo teojgo deleted the feat/show_compiler_flags branch October 24, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@teojgo teojgo

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w35

Development

Successfully merging this pull request may close these issues.

Show the compiler commands and flags in the --show-config-env option

3 participants

@teojgo @codecov-io @vkarak