[test] Make the MpiP check generic #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
changed the title
vkarak
requested changes
Sep 14, 2019
| if self.current_system.name == 'daint': | ||
| mpi_isendline = '142' | ||
| elif self.current_system.name == 'dom': | ||
| else self.current_system.name == 'dom': |
Contributor
There was a problem hiding this comment.
This syntax is invalid. Just else: should work. I'd recommend though not to change this elif, but add a default case with else that will be valid for any other system.
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
======================================
Coverage 91.7% 91.7%
======================================
Files 79 79
Lines 10486 10486
======================================
Hits 9616 9616
Misses 870 870Continue to review full report at Codecov.
|
Contributor
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for UES-535