Skip to content

[feat] Write the number of tasks in performance report #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 23, 2019
Merged

[feat] Write the number of tasks in performance report #976

merged 5 commits into from
Oct 23, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Oct 14, 2019 •
edited by vkarak
Loading

  • Change documentation regarding the performance report format.

Addresses #915.

Write the number of tasks in performance report
428f9fb 
* Change documentation regarding the performance report format.
@teojgo teojgo added this to the ReFrame Sprint 2019w41 milestone Oct 14, 2019
@teojgo teojgo requested a review from vkarak October 14, 2019 09:09
@teojgo teojgo self-assigned this Oct 14, 2019
@vkarak
Copy link
Contributor

vkarak commented Oct 17, 2019

This does not fix #915, but partially addresses it.

vkarak
vkarak requested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend this so that num_tasks is also allowed to be selected a log format parameter? We don't need a generic solution for the moment. Just add it as an additional field to select so as to address #915.

@pep8speaks
Copy link

pep8speaks commented Oct 22, 2019 •
edited
Loading

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-10-23 20:55:23 UTC

vkarak
vkarak requested changes Oct 23, 2019
View reviewed changes
@vkarak vkarak merged commit f69364d into reframe-hpc:master Oct 23, 2019
@vkarak vkarak mentioned this pull request Oct 23, 2019
Closed
@teojgo teojgo deleted the feat/num_tasks_report branch October 24, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame Sprint 2019w41

Development

Successfully merging this pull request may close these issues.

3 participants

@teojgo @vkarak @pep8speaks