[test] Remove workaround for NetCDF C++ test with PGI #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
approved these changes
Oct 16, 2019
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Apart from super().__init__() that can be deleted now, it looks good to me.
Contributor
|
will also fix #967 |
Contributor
Author
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 80 80
Lines 10674 10674
=======================================
Hits 9801 9801
Misses 873 873Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is now fixed and this flag is not needed. It actually makes the test fail.
Will fix MAINT-174