Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana VRM Changes #2

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Grafana VRM Changes #2

wants to merge 37 commits into from

Conversation

oshopgiri
Copy link

@oshopgiri oshopgiri commented Nov 6, 2020 •
edited
Loading

List of changes:

  • Support for Dynamic Variables in Alerts
  • User specific Alerts on Panels
    • Alert list panel will display Alerts specific to the logged in User
  • OAuth login via Refurbify
    • Auto-login (when the user is already logged into Refurbify)
    • Auto-signup with dynamic Role and Organisation assignment
    • Mapping Grafana Super Admin to all organisations as Admin
  • Update to the default Kiosk mode (kiosk=tv) to restrict Users from navigating away from a specific Dashboard
    • Dashboard search disabled
    • Cycle view button removed

Changes specific to role Editor and Viewer:

  • Sidemenu hidden
  • Dashboard search disabled
  • Can enlarge a Panel for detailed view
  • Editor can create Alerts by going into Panel Editor

@oshopgiri oshopgiri changed the base branch from staging to develop November 11, 2020 10:59
vinay and others added 13 commits January 8, 2021 10:25
@oshopgiri
Minor changes for making template variables dynamic for alerts. Remov…
9dd1f06 
…ed Validation for dynamic alerts.

## Added column userid in alerts table. Need to add DDL.
@ajuhia @oshopgiri
Chages to add new field(user_id) in alert table and code to handle th…
6344114 
…is field.
@oshopgiri
Change for alert functionality on template variables complete.
2adf123 
Added functionality for handeling "All" and "Multi Value" variables.
@ajuhia @oshopgiri
Changes done to restrict unauthorised user from updating alerts
1a01806
@ajuhia @oshopgiri
Multiple Changes related to save and retrieval of user specific alerts.
0a2a000
@oshopgiri
merging rebase changes
e51f669
@oshopgiri
adding code comments and markers to easily identify Clarity changes
7fb6c24
@oshopgiri
code refactored
e5d4e6a
@oshopgiri
test cases and code changes
679a211
@oshopgiri
adding config.yml for go test
3391a21
@oshopgiri
adding old config into config.yml
9d4aba7
@oshopgiri
fix to only run VRM tests
568315f
@oshopgiri
removing parallel testing
3d7cec1
@oshopgiri oshopgiri changed the title Grafana Multi-alert Feature Grafana VRM Changes Jan 25, 2021
ajuhia
ajuhia approved these changes Feb 3, 2021
View reviewed changes
Copy link

@ajuhia ajuhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes which were implemented as part of POC are present in this PR.

ronanmcnulty
ronanmcnulty approved these changes Feb 3, 2021
View reviewed changes
Copy link

@ronanmcnulty ronanmcnulty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

@oshopgiri
Copy link
Author

Please hold on merging this. Need to make a few fixes.

@oshopgiri
Copy link
Author

All fixes are in place now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronanmcnulty ronanmcnulty ronanmcnulty approved these changes

@ajuhia ajuhia ajuhia approved these changes

@chackoantony chackoantony Awaiting requested review from chackoantony

Assignees

@oshopgiri oshopgiri

@ajuhia ajuhia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshopgiri @ronanmcnulty @ajuhia