Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: stop uploading directories by passing nodir=true to glob #174
Thanks for such a cool tool! I have met an issue while trying to use this tool. I'm happy if you could see this change
What does this change?
A brief description of the issue
While publishing files, this tool tries to upload directories under the hard-to-happen condition. That is the case when a directory ends in file extension like
Under this condition, directories that have the name with file extension can be listed. As a result, file uploading would fail.
How did I solve it
It's easy to fix it because
I don't know we should have
More detailed story
I'm using Cypress for E2E tests in my project, and I wanted to try visual regression testing by this tool. In Cypress, it has a built-in screenshot function, which saves files into cypress/snapshots/[testfilename]/testname.png by default. Because of this Cypress's default naming rule, a directory is normally named with a file extension like
I tried GCS to save files, and it had raised an error like this.
That is the original motivation of this Pull Request.
No screenshots needed to check this change
What can I check for bug fixes?