Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make more arguments keyword only #368

Merged
merged 7 commits into from Aug 11, 2022
Merged

Conversation

mathause
Copy link
Member

This adds a helper to deprecate any number of positional arguments and deprecates some in for mask methods.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #368 (2248e37) into main (1a97d31) will decrease coverage by 0.04%.
The diff coverage is 97.43%.

❗ Current head 2248e37 differs from pull request most recent head 8df357b. Consider uploading reports for the commit 8df357b to get more accurate results

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   98.64%   98.59%   -0.05%     
==========================================
  Files          15       16       +1     
  Lines        1331     1357      +26     
==========================================
+ Hits         1313     1338      +25     
- Misses         18       19       +1     
Flag Coverage Δ
bare-minimum 91.51% <97.36%> (+0.09%) ⬆️
min-all-deps 97.80% <97.36%> (-0.04%) ⬇️
unittests 98.59% <97.43%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
regionmask/core/utils.py 100.00% <ø> (ø)
regionmask/core/_deprecate.py 96.42% <96.42%> (ø)
regionmask/core/_geopandas.py 97.56% <100.00%> (+0.12%) ⬆️
regionmask/core/plot.py 100.00% <100.00%> (ø)
regionmask/core/regions.py 97.88% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mathause mathause marked this pull request as ready for review August 11, 2022 16:28
@mathause mathause merged commit d76fe25 into regionmask:main Aug 11, 2022
@mathause mathause deleted the mask_keword_only branch August 11, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants