Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "close window" key binding to conky.config #3

Merged
merged 3 commits into from Jul 4, 2019

Conversation

3 participants
@eldelacajita
Copy link
Contributor

commented Jun 19, 2019

Super+Shift+q is a rather important shortcut. As a new i3 user, I found it confusing to not see a tip on how to close windows.

Feel free to reject this pull request if you think the new line should be added somewhere else!

Add "close window" key binding to conky.config
Super+Shift+q is a rather important shortcut. As a new i3 user, I found it confusing to not see a tip on how to close windows. 

Feel free to reject this pull request if you think the tip should be added somewhere else!
@kgilmer

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Thank you for your pull request @eldelacajita ! I don't see anything wrong with your commit. And I agree with you that it's confusing not to know how to close windows. I have one concern however. If you have a look at the i3wm user guide, this command may actually cause an application to be killed, meaning that any unsaved data would be lost.

This is one of the oddities of Linux (along w/ copy-paste), that there isn't consistency across applications. I find typically it's either ctrl-w or ctrl-q will close an app. But it can very and at this point in st, you have to type exit. (It's odd that I never found this to be a bad user experience until others noted it.)

So, I would like the conky shortcut text to indicate that the action will "kill" and not "quit" the application, to be somewhat safer. If you agree can you kindly update your PR?

@kgilmer

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Fixes #1. Actually closing the terminal is ctrl-d.

@eldelacajita

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Oh, I see, it's more complex than I thought. I'll try to rephrase it!

@eldelacajita

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Yeah, this seems a bit unreliable. In most apps it works gracefully (asking if you want to save work, saving state, etc.), but there may be unexpected exceptions, like precisely the default terminal. The Gnome terminal, also included, works great with Super+Shift+q.

How about something like this?

Ctrl+d$alignr Close active terminal
Super+Shift+q$alignr Kill active window
Ctrl+q (or other, by app)$alignr Quit active application
@eldelacajita

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Also, is there a reason why no system shutdown shortcut was added?

@Gabgab2003

This comment has been minimized.

Copy link

commented Jun 21, 2019

@eldelacajita I think the terminal and ctrl-q shouldn't be on the help menu for i3, because they aren't handled by i3. Just wording it "killing" should be enough that users get that the windows die

Improves wording of #20bc466
Changes "Close Window" to "Kill Active Window"
@eldelacajita

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Done! Is it correct now?

@kgilmer

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thanks for updating your patch @eldelacajita . Looks good except I'd like the new entry to go into the bottom section (the one that starts with Lock Screen). Regarding why there is no shortcut for system shutdown, it's just something I don't often do so didn't think to add it. In fact there is another user who's implemented a shutdown menu in Rofi. I haven't had a chance yet to integrate it for testing but may do so in the near future: regolith-linux/regolith-desktop#45

@eldelacajita

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Wouldn't it make more sense to have all the window-related actions together and leave the last section just for lock screen, sleep and logout? I'm adding a commit to show what I mean.

PS: This is my first attempt at making a PR and I'm having fun with it, but if you get bored and want to just edit the file yourself (which would have been the quick way to do this), feel free to do so and close this thread ;)

Change order of some elements
Moving all window-related actions together.
@kgilmer

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Agreed that this is better @eldelacajita . Thank you for your improvement to Regolith! If you'd like a Regolith sticker and care to send me a mailing address, send it to kgilmer@gmail.com and I'll send you one.

@kgilmer kgilmer merged commit 2bc2f08 into regolith-linux:master Jul 4, 2019

@eldelacajita eldelacajita deleted the eldelacajita:patch-1 branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.