New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default document visibility to true for SSR #2

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@sergiodxa
Contributor

sergiodxa commented Dec 6, 2018

In the case getVisibility() is run on SSR it will default document visibility to true to avoid breaking SSR.

Right now it breaks due document being undefined, I think it made sense to default to true.

Default document visibility to true for SSR
In the case `getVisibility()` is run on SSR it will default document visibility to `true` to avoid breaking SSR

@hanford hanford merged commit 3d41a68 into rehooks:master Dec 6, 2018

@hanford

This comment has been minimized.

Member

hanford commented Dec 6, 2018

thanks @sergiodxa, live in v1.2.0!

@sergiodxa sergiodxa deleted the sergiodxa:patch-1 branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment