New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of #1407 / #1413 (Navbar themes and fixes) #1415

Merged
merged 3 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@AbandonedCart
Contributor

AbandonedCart commented Sep 27, 2018

No description provided.

AbandonedCart added some commits Sep 27, 2018

Explicitely listing the http is an archaic concept
and it makes the words stretch into the artwork
@AbandonedCart

This comment has been minimized.

Contributor

AbandonedCart commented Sep 27, 2018

The irony of a point becoming moot as soon as you make it...

@AbandonedCart AbandonedCart merged commit cc217e9 into master Sep 27, 2018

9 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
wercker/build Wercker pipeline passed
Details

@AbandonedCart AbandonedCart deleted the ac/theme-a-palooza branch Sep 27, 2018

@baka0815

This comment has been minimized.

Collaborator

baka0815 commented Sep 27, 2018

Just curious: Why was this mergen where there is the "DO NOT MERGE" info in the header?

@AbandonedCart

This comment has been minimized.

Contributor

AbandonedCart commented Sep 27, 2018

#1407
#1413

The trend being both of them were merged before everything was verified.

@AbandonedCart AbandonedCart changed the title from [DO NOT MERGE] Continuation of (I don't know the numbers) to Continuation of #1407 / #1413 (Navbar themes and fixes) Sep 27, 2018

@MrPsyMan

This comment has been minimized.

Contributor

MrPsyMan commented Sep 27, 2018

Yeah, jumped into conclusions fast cause it looked pretty and such.

The sooner you fix it the sooner we'll have a pretty ui to work with.

@AbandonedCart

This comment has been minimized.

Contributor

AbandonedCart commented Sep 27, 2018

This was the last part. The forced update to API 26 means using all the half-implemented stuff, like enforcing tint that only works on vectors and vectors that only work in menus.

@MrPsyMan

This comment has been minimized.

Contributor

MrPsyMan commented Sep 27, 2018

Yeah, google -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment