Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upContinuation of #1407 / #1413 (Navbar themes and fixes) #1415
+58
−21
Conversation
AbandonedCart
added some commits
Sep 27, 2018
This comment has been minimized.
This comment has been minimized.
|
The irony of a point becoming moot as soon as you make it... |
AbandonedCart
merged commit cc217e9
into
master
Sep 27, 2018
9 checks passed
LGTM analysis: C/C++
No code changes detected
Details
LGTM analysis: JavaScript
No code changes detected
Details
LGTM analysis: Python
No code changes detected
Details
continuous-integration/appveyor/branch
AppVeyor build succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
license/cla
Contributor License Agreement is signed.
Details
wercker/build
Wercker pipeline passed
Details
AbandonedCart
deleted the
ac/theme-a-palooza
branch
Sep 27, 2018
This comment has been minimized.
This comment has been minimized.
|
Just curious: Why was this mergen where there is the "DO NOT MERGE" info in the header? |
This comment has been minimized.
This comment has been minimized.
AbandonedCart
changed the title from
[DO NOT MERGE] Continuation of (I don't know the numbers)
to
Continuation of #1407 / #1413 (Navbar themes and fixes)
Sep 27, 2018
This comment has been minimized.
This comment has been minimized.
|
Yeah, jumped into conclusions fast cause it looked pretty and such. The sooner you fix it the sooner we'll have a pretty ui to work with. |
This comment has been minimized.
This comment has been minimized.
|
This was the last part. The forced update to API 26 means using all the half-implemented stuff, like enforcing tint that only works on vectors and vectors that only work in menus. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, google -_- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AbandonedCart commentedSep 27, 2018
No description provided.