Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of #1407 / #1413 (Navbar themes and fixes) #1415

Merged
merged 3 commits into from Sep 27, 2018

Conversation

@AbandonedCart
Copy link
Contributor

@AbandonedCart AbandonedCart commented Sep 27, 2018

No description provided.

@AbandonedCart
Copy link
Contributor Author

@AbandonedCart AbandonedCart commented Sep 27, 2018

The irony of a point becoming moot as soon as you make it...

@AbandonedCart AbandonedCart merged commit cc217e9 into master Sep 27, 2018
@AbandonedCart AbandonedCart deleted the ac/theme-a-palooza branch Sep 27, 2018
@baka0815
Copy link
Contributor

@baka0815 baka0815 commented Sep 27, 2018

Just curious: Why was this mergen where there is the "DO NOT MERGE" info in the header?

@AbandonedCart
Copy link
Contributor Author

@AbandonedCart AbandonedCart commented Sep 27, 2018

#1407
#1413

The trend being both of them were merged before everything was verified.

@AbandonedCart AbandonedCart changed the title [DO NOT MERGE] Continuation of (I don't know the numbers) Continuation of #1407 / #1413 (Navbar themes and fixes) Sep 27, 2018
@MrPsyMan
Copy link
Contributor

@MrPsyMan MrPsyMan commented Sep 27, 2018

Yeah, jumped into conclusions fast cause it looked pretty and such.

The sooner you fix it the sooner we'll have a pretty ui to work with.

@AbandonedCart
Copy link
Contributor Author

@AbandonedCart AbandonedCart commented Sep 27, 2018

This was the last part. The forced update to API 26 means using all the half-implemented stuff, like enforcing tint that only works on vectors and vectors that only work in menus.

@MrPsyMan
Copy link
Contributor

@MrPsyMan MrPsyMan commented Sep 27, 2018

Yeah, google -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants