Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dropbox API from 1.6 to 3.0 #1425

Merged
merged 10 commits into from Oct 3, 2018
Merged

Update Dropbox API from 1.6 to 3.0 #1425

merged 10 commits into from Oct 3, 2018

Conversation

@AbandonedCart
Copy link
Contributor

@AbandonedCart AbandonedCart commented Oct 2, 2018

Not entirely sure if there is more to the login. Their documentation is a Javadoc and the samples are written like test modules meant to prove it functions with the least amount of code.

@AbandonedCart
Copy link
Contributor Author

@AbandonedCart AbandonedCart commented Oct 2, 2018

The number of method references in a .dex file cannot exceed 64K.
Between 20K - 30K are just the Dropbox SDK alone.

@AbandonedCart
Copy link
Contributor Author

@AbandonedCart AbandonedCart commented Oct 2, 2018

As a bonus, the compiled APK is 1.6 MB smaller overall after the addition of the absurdly bloated Dropbox SDK.

try {
file.createNewFile();
} catch (Exception e) {
// N+ files be broken

This comment has been minimized.

@skmp

skmp Oct 2, 2018
Member

Files are broken?

This comment has been minimized.

@AbandonedCart

AbandonedCart Oct 3, 2018
Author Contributor

File creation is broken.

@AbandonedCart AbandonedCart force-pushed the ac/dropbox branch from 5bb1ed5 to 843aafe Oct 3, 2018
@AbandonedCart AbandonedCart changed the title Attempt to update Dropbox API from 1.6 to 3.0 Update Dropbox API from 1.6 to 3.0 Oct 3, 2018
@AbandonedCart AbandonedCart merged commit d436c30 into master Oct 3, 2018
@AbandonedCart AbandonedCart deleted the ac/dropbox branch Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants