Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash on unaligned VRAM read access. Just return 0. #1426

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@flyinghead
Copy link
Contributor

@flyinghead flyinghead commented Oct 2, 2018

Fixes House of the Dead 2

Copy link
Contributor

@AbandonedCart AbandonedCart left a comment

🥇

@AbandonedCart AbandonedCart merged commit de5a04a into master Oct 2, 2018
@dmiller423
Copy link
Contributor

@dmiller423 dmiller423 commented Oct 2, 2018

Do we know the cause?
If the addr is aligned and returns data does it behave differently?
Does this happen running interpreter as well as recompiler / all platforms?
I have no issue with it being merged, i'm curious though to the cause.

Copy link
Contributor

@dmiller423 dmiller423 left a comment

addr & ~3
(addr+3) & ~3
?

@flyinghead flyinghead deleted the fh/unaligned-vram-access branch Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants