Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement layabout #2
This provides the implementation and code coverage for Layabout. There are a few unanswered questions marked with
In particular I'm curious about whether my very recent decision to make the
If you have the time I highly recommend installing the library via from this branch and playing around with it to get a feel for it.
$ pip install git+https://github.com/reillysiemens/layabout.git@implement-layabout
Overall it looks good. Pretty clean code and well documented.
Some over-arching questions:
- What is the
namefor, I never see it used outside a ToDo block.
- I see a theme of breaking code up into smaller more distinct single responsibility functions. Both in the client and the tests.
I'm not one of the project maintainers so I don't plan on giving an explicit approve or request changes on this one.
Just a few little things, then I'm ready to sign off on this.