Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow setting the host and port on a Statsd::Batch object #33

Merged
merged 1 commit into from Dec 21, 2012

Conversation

Projects
None yet
2 participants
Contributor

mzsanford commented Dec 21, 2012

I have some code that configured Statsd programmatically. In order to use Statsd::Batch as a drop-in replacement (config-wise) it needs to support the host and port setters so I added them in the attached pull request.

Collaborator

raggi commented Dec 21, 2012

So you're using batching without well defined flush boundaries? That's an interesting approach.

raggi added a commit that referenced this pull request Dec 21, 2012

Merge pull request #33 from mzsanford/configure_batch_parameters
Allow setting the host and port on a Statsd::Batch object

@raggi raggi merged commit 609b6f9 into reinh:master Dec 21, 2012

1 check passed

default The Travis build passed
Details
Contributor

mzsanford commented Dec 21, 2012

The batch size is set by the application code (which best understands that) but the host and port configuration varies. It's defaulted in the app and then our configuration is actually Ruby code which configures things per-environment (similar to Rails). We needed to set the host in production and found it didn't work after an application added batching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment