New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bind addresses for web and admin servers to be configurable #28

Merged
merged 2 commits into from Aug 11, 2015

Conversation

Projects
None yet
2 participants
@luismarques
Copy link
Contributor

luismarques commented Feb 23, 2015

No description provided.

ushort adminPort = 9009;
string databaseName = "vibenews";
string sslCertFile;
string sslKeyFile;
string[] webBindAddresses;
string[] adminBindAddresses;

This comment has been minimized.

@s-ludwig

s-ludwig Feb 23, 2015

Member

Indentation is off here (spaces vs. tabs).

@s-ludwig

This comment has been minimized.

Copy link
Member

s-ludwig commented Feb 23, 2015

LGTM otherwise!

@luismarques luismarques force-pushed the luismarques:feature_bind_addresses branch from 9d70989 to 85d478b Feb 28, 2015

@luismarques

This comment has been minimized.

Copy link
Contributor

luismarques commented Feb 28, 2015

I fixed the whitespace issue and squashed everything into a single commit (was that a bad idea?).

@luismarques

This comment has been minimized.

Copy link
Contributor

luismarques commented Aug 10, 2015

This is still open. Is anything missing?

@s-ludwig

This comment has been minimized.

Copy link
Member

s-ludwig commented Aug 11, 2015

Ah, no, looks good. Sorry, lost track of this.

s-ludwig added a commit that referenced this pull request Aug 11, 2015

Merge pull request #28 from luismarques/feature_bind_addresses
Allow bind addresses for web and admin servers to be configurable

@s-ludwig s-ludwig merged commit d72fc82 into rejectedsoftware:master Aug 11, 2015

@luismarques luismarques deleted the luismarques:feature_bind_addresses branch Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment