-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secret for private git #94
Conversation
It looks like you don't use encryption. Could you provide rationale for that decision? |
@yoquankara Thank you for your review.
And when we use them, we need to decode it -> https://github.com/rekcurd/dashboard/pull/94/files#diff-6e60f8497f16de75099b3715931c19c8R944 |
Base64 is simple to decode, so I wondered if it was better to add extra encryption as suggested here.
That said, encrypt data at rest is beta feature in v1.13 though. So we may consider it later. |
@yoquankara Yes I think so too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added #101 for later improvement
@yoquankara Thank you veeeeery much!! :) |
raise exception when adding git secret without k8s
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 83.69% 84.38% +0.68%
==========================================
Files 42 43 +1
Lines 2098 2235 +137
==========================================
+ Hits 1756 1886 +130
- Misses 342 349 +7
Continue to review full report at Codecov.
|
What is this PR for?
Add Git SSH Key management function for accessing a private git repository.
This PR includes
Kubernetes Secret
to store Git SSH KeyWhat type of PR is it?
Feature
What is the issue?
#76
How should this be tested?
Run unittest