Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added STM32 code, and fixes in Readme.MD #43

Merged
merged 16 commits into from Apr 22, 2019

Conversation

2 participants
@AdmiraalHugo
Copy link
Member

commented Apr 17, 2019

Hi, thanks for your contribution! Take a minute to tell us more about your changes:

Description

  • Added STM32 code
  • Made the needed changes to the Readme.MD
  • Fixed a few typo's in the Readme.MD
  • Added a NOTE about the exhibited stability issues of the Arduino DUE, and support of it.
  • Added a Pull request template, to make it more clear for people what they need to do, and to make it more easy for us to check them. (Looks the same like the one Im now using.

Motivation and Context

This changes "upgrade" the headset. The STM32 board is smaller, and cheaper than the Arduino DUE, and next to that, it resolves about 95% of the issues we had with OSVR. The code of the STM32 board is a lot more stabel then the Arduino DUE's code.

How Has This Been Tested?

All the code has been tested by Justin, Haagsch and me.

Those changes also effects the Arduino Libraries. All information about this can be found in the new Documentation, that has been written by Justin.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

AdmiraalHugo added some commits Apr 17, 2019

added STM32 code
Added STM32 code

Moved some files to different folders, to make the GitHub more userfriendly.
Removed a file
Removed a file, becuase the info has been added to the main README.md
Fixed link
Fixed the link for the face foam.
Fixed typo
Fixed a typo of the Biconvex lenses
Fixed typo's
Fixed a few more typo's in the Readme.MD

@AdmiraalHugo AdmiraalHugo requested review from maxime-coutte and al-haruun Apr 17, 2019

@AdmiraalHugo AdmiraalHugo changed the title Admiraal hugo patch 2 Added STM32 code, and fixes in Readme.MD Apr 17, 2019

AdmiraalHugo added some commits Apr 17, 2019

Added info Vang1 design
Added the amount of screws needed to make the Vang1 VR headset.
Added images
Added extra images, to help people build the headset.

@maxime-coutte maxime-coutte merged commit 5e4482e into master Apr 22, 2019

@maxime-coutte maxime-coutte deleted the AdmiraalHugo-patch-2 branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.