New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add support for xs:untypedAtomic and xs:anyAtomicType #230

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@ndw
Contributor

ndw commented Oct 31, 2018

Right. In the spirit of being helpful, I've made an admittedly somewhat crude stab at supporting xs:untypedAtomic and xs:anyAtomicType. Like xs:string, they accept anything. I think that's all that needs to be done from a validation perspective.

I added a couple of tests and the resulting jars work validating the real-world use case where I was attempting to declare an attribute as being any atomic type.

This PR would fix #229 if it was merged.

@sideshowbarker

Thanks — reviewed and tested

@sideshowbarker sideshowbarker merged commit e35062a into relaxng:master Oct 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sideshowbarker

This comment has been minimized.

Member

sideshowbarker commented Oct 31, 2018

I suppose this and some other changes that were merged recently merit tagging and doing actual (zipped jar) releases of the whole suite (trang, jing, and dtdinst) — so that, e.g., distro packagers can update from it.

Would it be worthwhile for me to make some time do that?

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 31, 2018

Yes, I think so. I'd be especially thankful if you pulled together the string, duct tape, and bubble gum necessary to get it published on a public Maven repository so that it could be included in projects with a dependency instead of having to package up a particular jar file.

@georgebina

This comment has been minimized.

Contributor

georgebina commented Oct 31, 2018

If we make a new release, maybe you can also review #209 so we can have that included in Jing. This is needed by DITA-OT to properly support DITA 1.3 which uses Relax NG schemas and needs the DTD compatibility support for default values.

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 31, 2018

👍 for #209 as well.

@sideshowbarker

This comment has been minimized.

Member

sideshowbarker commented Oct 31, 2018

Yes, I think so. I'd be especially thankful if you pulled together the string, duct tape, and bubble gum necessary to get it published on a public Maven repository so that it could be included in projects with a dependency instead of having to package up a particular jar file.

Yeah I know how to do that because I set it Maven releases that get published to https://repo1.maven.org/maven2/nu/validator/ — which actually includes a jing distribution (but for the branch/fork of jing that’s used for the Nu HTML checker/validator).

As far as where to publish releases from the (master/non-fork) branch here, I don’t have perms to publish to http://repo1.maven.org/maven2/com/thaiopensource/ (where previous releases of jing and trang live), but I guess I can ask for a Maven groupId of org.relaxng to be created, and the new jars could be made available as Maven artifacts from there.

So I’ll make some time to do that as well.

@sideshowbarker

This comment has been minimized.

Member

sideshowbarker commented Oct 31, 2018

If we make a new release, maybe you can also review #209 so we can have that included in Jing.

OK, yep, I will

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 31, 2018

That's fabulous. Thank you, @sideshowbarker !

@sideshowbarker

This comment has been minimized.

Member

sideshowbarker commented Nov 1, 2018

OK, created #231 to track getting a new release published here and at the Central Repo; as noted there:

As far as the Sonatype Central Repository, the jars will be published under the io.github.relaxng groupID — because I don’t have the admin access to either the relaxng.org nor thaiopensource.com domains to be able to prove to Sonatype that I have any association at all with those domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment