New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent schematron-related SXWN9000 Saxon error #244

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@sideshowbarker
Copy link
Member

sideshowbarker commented Dec 13, 2018

Fixes #240
See #240 (comment)

@rdeltour

This comment has been minimized.

Copy link

rdeltour commented Dec 13, 2018

I was originally reluctant to suggest directly touching the XSLT, since I didn't know where it came from or whether it was expected to be in sync with whatever upstream version… but looking closer at the code I concur with @georgebina that the proposed change s/b safe.
And I agree it’s better than #241 for the reasons stated by @ndw 😊

So LGTM!

@georgebina

This comment has been minimized.

Copy link
Contributor

georgebina commented Dec 13, 2018

We should apply the same fix to the ISO Schematron stylesheet - I know we do not fully support ISO Schematron, but we should keep the two stylesheets in sync.

@sideshowbarker sideshowbarker force-pushed the prevent-SXWN9000-Saxon-error branch from 87abde6 to c1d3486 Dec 13, 2018

@sideshowbarker

This comment has been minimized.

Copy link
Member

sideshowbarker commented Dec 13, 2018

We should apply the same fix to the ISO Schematron stylesheet - I know we do not fully support ISO Schematron, but we should keep the two stylesheets in sync.

OK, yep, done — and (force-)pushed to the branch in c1d3486

If we get agreement from @ndw on this, I’ll go ahead and merge it master and do a new release

@ndw

This comment has been minimized.

Copy link
Contributor

ndw commented Dec 21, 2018

If it passes tests and gets the blessing of my esteemed colleagues, 👍

@sideshowbarker sideshowbarker merged commit 411e1a7 into master Dec 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sideshowbarker sideshowbarker deleted the prevent-SXWN9000-Saxon-error branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment