Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added api docs #6

Merged
merged 2 commits into from Apr 14, 2019

Conversation

Projects
None yet
2 participants
@ndw
Copy link
Contributor

ndw commented Apr 3, 2019

This will fix #5

I ran the javadoc target on the latest jing-trang repo and copied the resulting API docs to /jclark/.

Ultimately, we should probably do better than just bolting in a particular version at this place. But the API doesn't change that often and this fixes the 404.

(Note: the build.xml file included an -html5 option that Java 8 didn't understand, so I took it out for this run.)

@ndw ndw requested review from sideshowbarker, jclark and murata2makoto Apr 3, 2019

@sideshowbarker
Copy link
Member

sideshowbarker left a comment

So I notice there are some 404s for an embedded resource: the jclark/api/datatype/stylesheet.css, jclark/api/jing/stylesheet.css, and jclark/api/regex/stylesheet.css files all have @import url('resources/fonts/dejavu.css') but there’s no resources subdirs at all in any of those subtrees.

But I dunno, maybe that was also true about the site contents before we moved the hosting to github.

Regardless, I don’t think that needs to block merging this PR to master.

I’m OK with either just ignoring it (because it doesn’t actually cause any user-observable problem), or else removing those @import url('resources/fonts/dejavu.css') parts from the stylesheets on this branch before merging — or else of course if we do have copies of the resources subdirectories somewhere, they could be git-added on this branch.

@sideshowbarker

This comment has been minimized.

Copy link
Member

sideshowbarker commented Apr 14, 2019

removing those @import url('resources/fonts/dejavu.css') parts from the stylesheets on this branch before merging

I went ahead and did that in 9e68ecb

@sideshowbarker sideshowbarker merged commit 2343b0f into relaxng:master Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.