Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Ensure session id is set to old ID #23

Merged
merged 1 commit into from Dec 7, 2016
Merged

Ensure session id is set to old ID #23

merged 1 commit into from Dec 7, 2016

Conversation

mattsah
Copy link
Contributor

@mattsah mattsah commented Dec 6, 2016

This fixes what appears to be a bug in the original reasoning and/or assumption found in the article here: http://paul-m-jones.com/archives/6310 and solves Issue #22 wherein even with session.use_only_cookies was true the setting of session.use_cookies to false caused PHP not to read the session ID from the cookie (at least in some circumstances).

In either case, setting the session_id() explicitly should work for all circumstances where an old id is present.

@pmjones
Copy link
Contributor

pmjones commented Dec 7, 2016

Wow, that's a good catch.

@pmjones pmjones merged commit 2f5e6e3 into relayphp:1.x Dec 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants