-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autorelease functionality #304
Closed
Closed
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7a3a5a2
basic functionality
b7e1fa5
version number got from tags
dfc1c77
configurable autorelease, default false
6458ce8
re-add husky
d3d04f2
add test for 'next version resolver'
7e56d14
add test for auto-config at index level
3475889
move to a switch statement -- bit more readable
86d9a2f
add TODO to ask community for feedback
4e0c93d
README updates
13b2400
do the version templating when getting the release info
1370af4
more config options for autorelease
1754466
configurable labels
6fd43c7
generalise config so that auto-release is a sub-action of increment-b…
9ff5d04
update README
0781aa3
case-insensitive matching
b2a0d4a
Clearer variable naming, move TODO down a level
601491c
Remove TODO about respecting templates...just don't
97efd12
Merge branch 'master' into autorelease
JimNero009 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
template: | | ||
# What's Changed | ||
|
||
$CHANGES | ||
|
||
auto-release: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jetersen What is the kind of thing you would like to see here? I'm starting to think that this has a fundamental flaw, and that I actually need to go back a few steps and interrupt the templating process for the name and tag variables to make sure they correspond to the version that is just about to be released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From above you should have:
https://github.com/toolmantim/release-drafter/blob/4e0c93d4a6c5296d865ca2dcd1e4c54d9058c531/index.js#L71-L76
you should have access to
releaseInfo.name
andreleaseInfo.tag
Perhaps your
incrementVersionBasedOnLabels
should update thereleaseInfo.tag
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, of course! Not sure how I didn't see that.
So yeah -- when generating the release info, I can just hook right into that and get it to resolve to different version numbers based on labels. Shouldn't be too difficult... 😅