Make deployment cleaner #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps generate a deployment package. Run "tox -e package" and the resulting package.zip is ready for upload to AWS. The deployment package is created using pip.
Previously, the relevant lambda function we want to use was located at: cdn_lambda.functions.map_to_s3.map_to_s3.lambda_handler ...and this function name needs to be used when configuring the lambda in AWS. Alternatively, one could create the deployment package by zipping up cdn_lambda/functions/map_to_s3 rather than the entire module and using a shorter name. Either option there is cumbersome and leaks details about how the modules are structured internally, which could lead to cases where we have to make changes to the lambda function config because we refactored some modules. It seems more stable and maintainable if we make sure there are top-level imports for anything we expect to be invoked as a lambda function. We can use the convention of naming them after their trigger to denote how they're expected to be used. This means that the function intended to be used with origin request events can now be accessed as: cdn_lambda.origin_request ...which is brief, easy to understand and easy to keep working even if we change completely how the Python modules are arranged internally.
Contributor
Author
|
@crungehottman @nathanegillett The background here is that I was looking at the lambda functions which had been previously deployed, and saw for instance a 'map_to_s3.lambda_handler' which seems to require zipping up specifically the cdn_lambda/functions/map_to_s3 directory. It seems rather messy, e.g. it breaks normal Python import behavior (imagine if map_to_s3 imports some cdn_lambda.utils - it'll work fine for autotests in this repo, then break when you go to deploy it). |
negillett
requested changes
Feb 27, 2020
negillett
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard way of doing it
doesn't influence AWS configs
See individual commits for more details.