Add support for podman compose #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
reviewed
Aug 10, 2020
|
@lcarva Is this still a draft? Or is it ready for review? |
I think the one thing I'd like to do is create a little |
|
This is ready for review and no longer in draft state. |
mprahl
approved these changes
Oct 7, 2020
podman rootless cannot access the file directly due to selinux Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
ActiveMQ and RabbitMQ both use the port 5762. Even though the port is not exposed on both containers, podman-compose's use of a pod requires the ports to be unique across all containers within the pod. Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
|
Fixed the travis issue by rebasing on master and picking up the safety fix. |
yashvardhannanavati
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rough draft of what it takes to run IIB with podman.
I managed to make this work on fedora 31 by using my fork of podman-compose on the branch super-duper, https://github.com/lcarva/podman-compose/tree/super-duper. This fork has a few different things that improve the experience drastically (PRs have been created for each commit):
down -vso volumes are removed.But more importantly, it's based on the devel branch of podman-compose which contains a lot of fixes not found in the rpm distribution.
The changes in this PR are the bare minimum to work with podman-compose. Each commit, hopefully, explain why the change is needed.
If this is something we want to pursue further, we can probably create a
Makefileto handle the copy of the system ca bundle while starting up the docker/podman-compose.