Add preliminary support for container-related push items #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
force-pushed
the
rohan/errata-containers-prelim
branch
from
f7cef46 to
8291b7f
Compare
This commit introduces support for two new push item types which can now be located by errata or koji source: - ContainerImagePushItem: a container image - OperatorManifestPushItem: operator manifests bundle typically found alongside container images in koji This is referred to as "preliminary support" because these classes haven't defined any attributes yet (i.e. they only have the inherited attributes from the base PushItem class). This is done to avoid the change becoming too large and complicated. In this commit, we focus only on how we locate these push items when given an advisory; filling out the model with all needed attributes will come later, and it's expected to be rather complicated to figure out what's needed there.
rohanpm
force-pushed
the
rohan/errata-containers-prelim
branch
from
8291b7f to
289b2ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for two new push item types which can now
be located by errata or koji source:
ContainerImagePushItem: a container image
OperatorManifestPushItem: operator manifests bundle typically found
alongside container images in koji
This is referred to as "preliminary support" because these classes
haven't defined any attributes yet (i.e. they only have the inherited
attributes from the base PushItem class). This is done to avoid the
change becoming too large and complicated.
In this commit, we focus only on how we locate these push items when
given an advisory; filling out the model with all needed attributes
will come later, and it's expected to be rather complicated to figure
out what's needed there.