From 5d53f546f6f6b79c266fa9cfb5b5505c4d6ad3f7 Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Tue, 10 Aug 2021 16:22:58 +1000 Subject: [PATCH] Fix missing dependency 'scandir' on older python We try to use os.scandir, but fall back to scandir.scandir on python < 3.5; this dependency wasn't declared, and it should be. Previously missed because, on those python versions, scandir tends to be pulled in via pytest => pathlib during tests. But this is not true for all versions of pytest. --- CHANGELOG.md | 4 +++- requirements.txt | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75c1ee04..d13ae497 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -- n/a +### Fixed + +- Added a missing dependency declaration on `scandir` for Python versions older than 3.5. ## [2.10.0] - 2021-08-10 diff --git a/requirements.txt b/requirements.txt index d36700a5..7b7d9b78 100644 --- a/requirements.txt +++ b/requirements.txt @@ -4,6 +4,7 @@ koji>=1.18 six pushcollector PyYAML +scandir; python_version < '3.5' frozendict; python_version >= '3.6' frozenlist2 python-dateutil