From deff390f96523ed809150fb1a40e712fe0759196 Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Thu, 26 Aug 2021 09:29:08 +1000 Subject: [PATCH] Fix koji version method 2.10.2 had a trivial but showstopping bug: the method we want to call here is actually getKojiVersion, not getVersion. The latter doesn't exist, which means the code immediately crashes when used against a real koji server. --- src/pushsource/_impl/backend/koji_source.py | 2 +- tests/koji/fake_koji.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pushsource/_impl/backend/koji_source.py b/src/pushsource/_impl/backend/koji_source.py index 6bdd282c..e6d23c8f 100644 --- a/src/pushsource/_impl/backend/koji_source.py +++ b/src/pushsource/_impl/backend/koji_source.py @@ -255,7 +255,7 @@ def _koji_check(self): def _koji_get_version(self): with CACHE_LOCK: if "koji_version" not in self._cache: - self._cache["koji_version"] = self._koji_session.getVersion() + self._cache["koji_version"] = self._koji_session.getKojiVersion() return self._cache["koji_version"] def _get_rpm(self, rpm): diff --git a/tests/koji/fake_koji.py b/tests/koji/fake_koji.py index df72893e..c6abec98 100644 --- a/tests/koji/fake_koji.py +++ b/tests/koji/fake_koji.py @@ -158,7 +158,7 @@ def _return_or_raise(self, value): raise value return value - def getVersion(self): + def getKojiVersion(self): return "fake-version" def getRPM(self, rpm):