Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add If-Modified-Since field to call URL header #778

Merged
merged 1 commit into from Aug 16, 2019

Conversation

Zlopez
Copy link
Contributor

@Zlopez Zlopez commented May 7, 2019

This prevents downloading the page each time check is performed
on project. Instead use the time when latest version was obtained as
reference in If-Modified-Since field in HTML header.

Closes #730

Signed-off-by: Michal Konečný mkonecny@redhat.com

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #778 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   97.07%   97.11%   +0.04%     
==========================================
  Files          59       59              
  Lines        3354     3401      +47     
  Branches      406      421      +15     
==========================================
+ Hits         3256     3303      +47     
  Misses         59       59              
  Partials       39       39
Impacted Files Coverage Δ
anitya/db/models.py 100% <100%> (ø) ⬆️
anitya/lib/backends/crates.py 100% <100%> (ø) ⬆️
anitya/lib/backends/gnu.py 100% <100%> (ø) ⬆️
anitya/lib/backends/folder.py 96.96% <100%> (+0.3%) ⬆️
anitya/lib/backends/rubygems.py 94.59% <100%> (+0.47%) ⬆️
anitya/lib/backends/pypi.py 100% <100%> (ø) ⬆️
anitya/lib/backends/cran.py 100% <100%> (ø) ⬆️
anitya/lib/backends/pagure.py 96.29% <100%> (+0.46%) ⬆️
anitya/lib/backends/gitlab.py 100% <100%> (ø) ⬆️
anitya/lib/backends/npmjs.py 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e78a4c...019e15c. Read the comment docs.

This prevents downloading the page each time check is performed
on project. Instead use the time when latest version was obtained as
reference in If-Modified-Since field in HTML header.

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@Zlopez Zlopez merged commit e535e4a into fedora-infra:master Aug 16, 2019
@Zlopez Zlopez deleted the modified-since branch October 8, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad robot
2 participants