Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ecosystem when homepage or backend is changed #859

Merged
merged 1 commit into from Dec 17, 2019

Conversation

Zlopez
Copy link
Contributor

@Zlopez Zlopez commented Dec 12, 2019

Till now ecosystem was only set once, when project was created. With
this commit ecosystem is changed when homepage or backend change is
emitted. The ecosystem value is set as follows:

  • Ecosystem is set using backend if backend is associated with ecosystem
  • Ecosystem is set to homepage

Fixes #764

Signed-off-by: Michal Konečný mkonecny@redhat.com

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #859 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   97.33%   97.33%   +<.01%     
==========================================
  Files          61       61              
  Lines        3675     3676       +1     
  Branches      497      494       -3     
==========================================
+ Hits         3577     3578       +1     
  Misses         58       58              
  Partials       40       40
Impacted Files Coverage Δ
anitya/db/events.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d247c8b...3a7ae6e. Read the comment docs.

anitya/db/__init__.py Outdated Show resolved Hide resolved
anitya/db/events.py Outdated Show resolved Hide resolved
anitya/db/events.py Outdated Show resolved Hide resolved
anitya/db/__init__.py Outdated Show resolved Hide resolved
Till now ecosystem was only set once, when project was created. With
this commit ecosystem is changed when homepage or backend change is
emitted. The ecosystem value is set as follows:
 - Ecosystem is set using backend if backend is associated with ecosystem
 - Ecosystem is set to homepage

Fixes fedora-infra#764

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Copy link
Member

@nphilipp nphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 71c94a4 into fedora-infra:master Dec 17, 2019
@Zlopez Zlopez deleted the 764 branch October 8, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If URL is changed, update ecosystem value as well
3 participants