Fixing, cleaning and new features #7

Closed
wants to merge 6 commits into from

3 participants

@alistairholt
  • Add missing development dependencies
  • Bring .rvmrc up-to-date with current conventions
  • Add support for Bundler
  • Add support for object inspection via awesome_print
  • Fix warnings about calling #split on nil
@rsanheim rsanheim commented on the diff Feb 3, 2012
+ fi
+else
+ # If the environment file has not yet been created, use the RVM CLI to select.
+ if ! rvm --create "$environment_id"
+ then
+ echo "Failed to create RVM environment '${environment_id}'."
+ return 1
+ fi
+fi
+
+if [[ $- == *i* ]] # check for interactive shells
+then
+ echo "Using: $(tput setaf 2)$GEM_HOME$(tput sgr0)" # show the user the ruby and gemset they are using in green
+else
+ echo "Using: $GEM_HOME" # don't use colors in interactive shells
+fi
@rsanheim
rsanheim added a note Feb 3, 2012

Hey why would rvmrc need to be so complicated?

Also, I'm not sold on using a gemset, especially since bundler should manage the gems.

I agree about the complexity, it's just what RVM generates by default. I personally use a gemset for each project I'm working on to keep things clean and avoid gem version issues but that's just me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rsanheim

Thanks for the bundler addition, would like to merge that part. The awesome print stuff is fine, too, though I haven't used it. Long term I suppose there should be a more general way to define how log buddy prints stuff.

@alistairholt

I'm currently using my fork and the awesome_print functionality is working really well for me.

@cldwalker

I've pulled in use_awesome_print and the warnings fix. Thanks!

@cldwalker cldwalker closed this Apr 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment